rrd improvements #326
Merged
rrd improvements #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mambelli
force-pushed
the
v310/rrd_improvements
branch
from
244131c
to
6d60599
Compare
mambelli
force-pushed
the
v310/rrd_improvements
branch
from
538227d
to
5bef86b
Compare
namrathaurs
requested changes
Aug 14, 2023
mambelli
changed the title
Fixed bug: rrdtools_exe.dump() was wrongly decoding the output of subprocessSupport.iexe_cmd() which is already a string Code improvements, no specific bug fix: creating also parent directories, eliminated nested os.path.join calls, better docstrings, consolidated tmp2final verifyHelper functions, eliminated global variable use, use os.path.join instead of string concatemation with /
mambelli
force-pushed
the
v310/rrd_improvements
branch
from
5bef86b
to
9f3f574
Compare
namrathaurs
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code improvements in RRD handling code, no specific bug fix:
os.path.joincalls,os.path.joininstead of string concatenation with/Also improved docstrings
The exception improvements changes have been separated out in PR #330